Merged
Conversation
Deploying utcode-learn with
|
| Latest commit: |
18d8b59
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5e3372f2.utcode-learn.pages.dev |
| Branch Preview URL: | https://fix-in-form.utcode-learn.pages.dev |
chvmvd
reviewed
May 25, 2024
Contributor
chvmvd
left a comment
chvmvd
left a comment
There was a problem hiding this comment.
全体的に良さそうだけど、「移る」のニュアンスがなくなるのは、微妙かも。
「移る」がなかったら、普通にJavaScriptのイベントと同じじゃんとなりそう。まあ、内部的には現在だと同じ場合もあるわけだけど。ユーザーエクスペリエンス的には、この2つはかなり違うから(というよりもユーザーエクスペリエンスのためにこういうことをするわけだけど)。
chvmvd
reviewed
May 26, 2024
Contributor
chvmvd
left a comment
chvmvd
left a comment
There was a problem hiding this comment.
ただ文章が難しくなっただけで、結局何も変わっていないような...
chvmvd
reviewed
Jun 9, 2024
Contributor
chvmvd
left a comment
chvmvd
left a comment
There was a problem hiding this comment.
結局、何を解決したかったのかわかりませんでした...
Contributor
って感じなんですかね？ |
nakaterm
approved these changes
Jun 10, 2024
Contributor
Author
|
次に移る（表示される）ページが異なるウェブページがあります |
Contributor
Author
です |
chvmvd
approved these changes
Jul 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.